Skip to content

Commit

Permalink
[swift] Skip overridden properties/fields with incompatible nullability
Browse files Browse the repository at this point in the history
  • Loading branch information
lemonmojo committed Feb 25, 2025
1 parent 709f2f8 commit b760397
Showing 1 changed file with 13 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ out string generatedName
if (nonByRefParameterType.IsArray) {
generatedName = string.Empty;

return "// TODO: Generic Methods with out/in/ref parameters that are arrays are not supported";
return "// TODO: Generic Methods with out/in/ref parameters that are arrays are not supported";
}
}
}
Expand All @@ -182,7 +182,18 @@ out string generatedName
bool isActuallyOverridden = methodInfo.IsOverridden(out bool overrideNullabilityIsCompatible);

if (isActuallyOverridden) {
if (overrideNullabilityIsCompatible) {
if (memberKind == MemberKind.FieldGetter ||
memberKind == MemberKind.FieldSetter ||
memberKind == MemberKind.PropertyGetter ||
memberKind == MemberKind.PropertySetter) {
if (overrideNullabilityIsCompatible) {
treatAsOverridden = true;
} else {
generatedName = string.Empty;

return "// TODO: Overridden property or field with incompatible nullability";
}
} else { // Method
treatAsOverridden = true;
}
} else {
Expand Down

0 comments on commit b760397

Please sign in to comment.