Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable fonts report incorrect version #202

Closed
lordsutch opened this issue Sep 13, 2019 · 3 comments
Closed

Variable fonts report incorrect version #202

lordsutch opened this issue Sep 13, 2019 · 3 comments
Labels
bug Something that is now the way it's supposed to be

Comments

@lordsutch
Copy link

Describe the bug
In the Inter-3.10.zip archive, the variable fonts report a version of "1.0.0;git-src" rather than "3.010;git-aca7606f2" as shown by the other OpenType/TrueType font files. This makes it difficult to tell if the installed versions of the variable fonts are out of date.

It appears that the updateFontVersion() call in VarFontProject._build_interpolatable_masters() at https://github.com/rsms/inter/blob/master/misc/fontbuild#L185 does not have the intended effect of updating the version information in the variable font.

To Reproduce
Steps to reproduce the behavior (at a command line):

  1. Run (e.g.) otfinfo -v Inter\ (OTF)/Inter-Italic.otf
  2. Run (e.g.) otfinfo -v Inter\ (TTF\ variable)/Inter-italic.var.ttf

Expected behavior
Both otfinfo commands should show the same output: "Version 3.010;git-aca7606f2"

Environment

  • OS: macOS 10.14.6 - but this should be OS-agnostic
  • Version of font: 3.10 (3.010;git-aca7606f2)
@rsms
Copy link
Owner

rsms commented Oct 21, 2019

Thank you. This is a know bug in the latest release. It’s due to changes to a library that the build toolchain uses and we’re working on a fix.

@rsms rsms added the bug Something that is now the way it's supposed to be label Oct 21, 2019
@rsms rsms closed this as completed in 0ba7c2b Oct 22, 2019
@rsms
Copy link
Owner

rsms commented Oct 22, 2019

This was a regression introduced in a recent upgrade of one of the 3rd party libraries used by fontbuild (fontmake).

Here is a build from master as is at the time of writing this comment.
Inter-3.11-ba71122abf.zip

@rsms
Copy link
Owner

rsms commented Oct 23, 2019

New release is out that includes a fix: https://github.com/rsms/inter/releases/tag/v3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is now the way it's supposed to be
Projects
None yet
Development

No branches or pull requests

2 participants