Merge pull request #741 from nobu/ctype-plain-char

Avoid plain char for ctype macros
ruby · Jan 30, 2025 · 1023227 · 1023227
2 parents f3fb8a2 + 4431b36
commit 1023227
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ext/json/ext/parser/parser.c b/ext/json/ext/parser/parser.c
@@ -135,7 +135,7 @@ static VALUE rstring_cache_fetch(rvalue_cache *cache, const char *str, const lon
         return Qfalse;
     }
 
-    if (RB_UNLIKELY(!isalpha(str[0]))) {
+    if (RB_UNLIKELY(!isalpha((unsigned char)str[0]))) {
         // Simple heuristic, if the first character isn't a letter,
         // we're much less likely to see this string again.
         // We mostly want to cache strings that are likely to be repeated.
@@ -187,7 +187,7 @@ static VALUE rsymbol_cache_fetch(rvalue_cache *cache, const char *str, const lon
         return Qfalse;
     }
 
-    if (RB_UNLIKELY(!isalpha(str[0]))) {
+    if (RB_UNLIKELY(!isalpha((unsigned char)str[0]))) {
         // Simple heuristic, if the first character isn't a letter,
         // we're much less likely to see this string again.
         // We mostly want to cache strings that are likely to be repeated.