Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner Added Email: It does not mention the right role for the new owner (when owner is a maintainer) #5445

Open
etagwerker opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@etagwerker
Copy link

etagwerker commented Feb 10, 2025

Steps to Reproduce

  1. Add an owner
  2. Set the new owner with the maintainer role
  3. Get an email from Rubygems.org

Expected Behavior

I'd expect the email to use the right role (e.g. maintainer): "User was added as a maintainer..."

Current Behavior

I see that the email says that the new maintainer is added as an owner which causes unexpected confusion.

Image

Possible Solution

Incorporate the role to the email that is being sent?

I see two potential solutions:

  1. Tweak https://github.com/rubygems/rubygems.org/blob/master/app/views/owners_mailer/owner_added.html.erb to mention the role of the new owner
  2. Generate a new mailer method (think owner_added vs. maintainer_added) the email template would be very similar

Environment

All browsers.

Additional Context

I believe the maintainer role was added here: #4883

Maybe it missed updating the email?

@etagwerker etagwerker added the bug label Feb 10, 2025
@etagwerker etagwerker changed the title Email does not mention the right role for the new owner Owner Added Email: It does not mention the right role for the new owner (when owner is a maintainer) Feb 10, 2025
@segiddins segiddins added this to the Organizations milestone Feb 11, 2025
@colby-swandale colby-swandale self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants