feat: minio testhelper add content method #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
approved these changes
Jun 11, 2024
fracasula
approved these changes
Jun 12, 2024
| @@ -116,3 +126,46 @@ func Setup(pool *dockertest.Pool, d resource.Cleaner, opts ...func(*Config)) (*R | |||
| Client: client, | |||
| }, nil | |||
| } | |||
|
|
|||
| func (r *Resource) Contents(ctx context.Context, prefix string) ([]File, error) { | |||
There was a problem hiding this comment.
[nitpick] This receiver has a different name than the other one. We could name both r.
| Recursive: true, | ||
| Prefix: prefix, | ||
| } | ||
| for objInfo := range r.Client.ListObjects(ctx, r.BucketName, opts) { |
There was a problem hiding this comment.
What happens if the context gets cancelled? Don't we have to check objInfo.Err? 🤔
| var r io.Reader | ||
| br := bufio.NewReader(o) | ||
| magic, err := br.Peek(2) | ||
| if err == nil && magic[0] == 31 && magic[1] == 139 { |
There was a problem hiding this comment.
Can we have a comment here please?
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add content method to testhelper minio resource, to avoid code repetition in tests.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1179/rudder-go-kit-testhelper-miniocontents
resolves PIPE-1179
Security