Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key "batch" was being obfuscated due to proguard #423

Conversation

itsdebs
Copy link
Contributor

@itsdebs itsdebs commented May 17, 2024

Mentioned the serialized name as annotation.
As a safeguard also added the file to proguard rules

Fixes # (issue)
sdk-1774

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

Mentioned the serialized name as annotation.
As a safeguard also added the file to proguard rules
@itsdebs itsdebs requested a review from 1abhishekpandey May 17, 2024 06:04
@itsdebs itsdebs requested a review from ChryssaAliferi as a code owner May 17, 2024 06:04
@itsdebs itsdebs changed the title fix: "batch" was being obfuscated due to proguard. fix: key "batch" was being obfuscated due to proguard. May 17, 2024
@itsdebs itsdebs changed the title fix: key "batch" was being obfuscated due to proguard. fix: key "batch" was being obfuscated due to proguard May 17, 2024
@itsdebs itsdebs requested a review from 1abhishekpandey May 17, 2024 09:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@itsdebs itsdebs merged commit eaa282c into develop May 20, 2024
8 checks passed
@itsdebs itsdebs deleted the feature/sdk-1774-fix-malform-events-in-dmt-request-for-minify-enabled-apps branch May 20, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants