Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable static framework setting in Kochava iOS Integration Podspec #166

Merged

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented May 16, 2024

About the issue

Our Flutter Kochava iOS integration throws the following transitive dependency issue if it's installed while having use_frameworks! in the Flutter-iOS app Podspec file:

[!] The 'Pods-Runner' target has transitive dependencies that include statically linked binaries: (Rudder-Kochava)

About the fix

We attempted to solve this issue by enabling the static framework setting in the Kochava iOS integration.

About chore changes

For the Flutter sample iOS app, I've changed from use_frameworks! :linkage=> :static to use_frameworks!. This is to ensure that we perform a default check for the dynamic linkage in the future and prevent this kind of error.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@1abhishekpandey 1abhishekpandey self-assigned this May 16, 2024
@1abhishekpandey 1abhishekpandey requested a review from a team as a code owner May 16, 2024 12:37
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@1abhishekpandey 1abhishekpandey merged commit da51744 into develop May 17, 2024
20 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix/sdk-1735-fix-flutter-kochava-ios-integration-issue branch May 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants