feat: support for databricks oauth #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar-rudder
requested review from
atzoum and
RanjeetMishra
as code owners
achettyiitr
reviewed
Feb 21, 2025
| strings.ToLower, | ||
| integrationtest.Options{ | ||
| LegacySupport: true, | ||
| SpecialCharactersInQuotedTable: "_A", |
There was a problem hiding this comment.
What's this use for? It's different from what is being used for with information schema suite.
Suggested change
| SpecialCharactersInQuotedTable: "_A", | |
| SpecialCharactersInQuotedTable: "_A", |
There was a problem hiding this comment.
Not sure. I copied it as it is from an existing test
shekhar-rudder
force-pushed
the
war-335-databricks-oauth
branch
from
262ebff to
c64eba0
Compare
achettyiitr
reviewed
Feb 21, 2025
| @@ -49,6 +49,31 @@ func TestDatabricksDB(t *testing.T) { | |||
| ) | |||
| }) | |||
|
|
|||
| t.Run("with oauth", func(t *testing.T) { | |||
| oauthConfigJSON, ok := os.LookupEnv("DATABRICKS_OAUTH_TEST_ENVIRONMENT_CREDENTIALS") | |||
There was a problem hiding this comment.
Are these credentials store somewhere in notion? DATABRICKS_OAUTH_TEST_ENVIRONMENT_CREDENTIALS
There was a problem hiding this comment.
No, I had created it yesterday for the POC. Added the same in Github.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 85.56% 85.57% +0.01%
==========================================
Files 88 88
Lines 4579 4583 +4
==========================================
+ Hits 3918 3922 +4
Misses 502 502
Partials 159 159 ☔ View full report in Codecov by Sentry. |
achettyiitr
approved these changes
Feb 21, 2025
atzoum
approved these changes
Feb 25, 2025
Merged
shekhar-rudder
pushed a commit
that referenced
this pull request
Feb 27, 2025
🤖 I have created a release *beep* *boop* --- ## [1.18.0](v1.17.0...v1.18.0) (2025-02-25) ### Features * support for databricks oauth ([#286](#286)) ([4df34db](4df34db)) ### Miscellaneous * **deps:** bump github.com/aws/aws-sdk-go-v2/config from 1.29.4 to 1.29.7 ([#287](#287)) ([5c3cbb3](5c3cbb3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances Databricks authentication by adding support for OAuth authorization alongside the existing PAT-based method.
DATABRICKS_OAUTH_TEST_ENVIRONMENT_CREDENTIALS, has been added for integration testing.Security