Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try adopting taiki-e/cargo-llvm-cov#141 for better reports #3

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ruifengx
Copy link
Owner

@ruifengx ruifengx commented Mar 2, 2022

Coverage dropped drastically (~90% to ~25%) after Nov 30, 2021, but the code was not modified at all. It is only possible due to the change in either rustc or cargo-llvm-cov. Let's first try to downgrade the easy one and see what's going on.

@coveralls
Copy link

coveralls commented Mar 2, 2022

Pull Request Test Coverage Report for Build 1921934846

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+66.0%) to 91.009%

Files with Coverage Reduction New Missed Lines %
src/backend/dfa.rs 1 95.54%
src/backend/lalr1.rs 6 82.96%
Totals Coverage Status
Change from base Build 1921279985: 66.0%
Covered Lines: 2065
Relevant Lines: 2269

💛 - Coveralls

@ruifengx
Copy link
Owner Author

ruifengx commented Mar 2, 2022

Apparently the result doesn't seem right, either. Let's try the fix taiki-e/cargo-llvm-cov#141.

@ruifengx ruifengx force-pushed the downgrade-cargo-llvm-cov branch from 64c7b1e to fb97d37 Compare March 2, 2022 11:32
@ruifengx ruifengx changed the title try downgrade cargo-llvm-cov for better reports try adopting taiki-e/cargo-llvm-cov#141 for better reports Mar 2, 2022
@ruifengx
Copy link
Owner Author

ruifengx commented Mar 2, 2022

Looks good, gonna merge this.

This would be a temporary fix: come back at this when the upstream PR is merged.

@taiki-e
Copy link

taiki-e commented Apr 8, 2022

FYI, I've just published cargo-llvm-cov 0.3.0 which includes taiki-e/cargo-llvm-cov#141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants