Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exposes BGZF writing capabilities. This is my first time writing unsafe code (outside of tutorials), so some extra attention there would be welcomed. :)
One possibly controversial implementation choice I made:
BGZF supports two different versions of "No Compression." The value
-2
/wu
results in a "bgzf" writer that simply passes the input through without modifying it - the output file should be the exact same as the input. The value0
/w0
results in a more normal/usual "Uncompressed" setting, where the output is conforming bgzf format, but doesn't try to compress it.I chose to expose both of these, calling the first one "NoCompression" and the latter "Uncompressed." These names aren't clear in how they differ, so I would be happy for them to be renamed - or, if the situation is too confusing, removing NoCompression.
If accepted, this PR should close #347.