Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Clone for bcf::Record #394

Merged
merged 1 commit into from
Jun 5, 2023
Merged

feat: implement Clone for bcf::Record #394

merged 1 commit into from
Jun 5, 2023

Conversation

astaric
Copy link
Contributor

@astaric astaric commented May 26, 2023

wrapper for htslib::bcf_dup function

@astaric
feat: implement Clone for bcf::Record
54de618 
wrapper for htslib::bcf_dup function
dlaehnemann
dlaehnemann approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, many thanks. Will merge, once the tests pass!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5088068006

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 79.377%
Files with Coverage Reduction New Missed Lines %
src/bgzf/mod.rs 3 67.42%
Totals Coverage Status
Change from base Build 4991305026: 0.07%
Covered Lines: 2344
Relevant Lines: 2953
💛 - Coveralls

@dlaehnemann dlaehnemann merged commit e89538d into rust-bio:master Jun 5, 2023
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaehnemann dlaehnemann dlaehnemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astaric @coveralls @dlaehnemann