You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noticed when trying to change embedded-hal to edition 2018, a number of examples using the nb::await! macro fail to compile: rust-embedded/embedded-hal#167
However async/await is currently not available in no_std due to the implicit use of TLS.
Can we come up with some workaround might would us to unbreak the use of the primitives provided by this crate or should we leave nb unchanged and remove the offending examples until async/await becomes usable?
I updated review and temporary fixed problems with nb but it doesn't sounds good - It looks like a hack: r# prefixes wouldn’t be an ergonomic solution that users are familiar with.
Initial review was merged. Now I have some solution - replace everything of nb use to core::task::Poll: rust-embedded/embedded-hal#171. But I have no solution to change nb package as crate.
As noticed when trying to change
embedded-hal
to edition 2018, a number of examples using thenb::await!
macro fail to compile: rust-embedded/embedded-hal#167However async/await is currently not available in
no_std
due to the implicit use of TLS.Can we come up with some workaround might would us to unbreak the use of the primitives provided by this crate or should we leave
nb
unchanged and remove the offending examples until async/await becomes usable?cc @japaric
cc @Nemo157
cc @no111u3
The text was updated successfully, but these errors were encountered: