Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb is incompatible with async/await which is now in stable #19

Closed
therealprof opened this issue Nov 19, 2019 · 3 comments
Closed

nb is incompatible with async/await which is now in stable #19

therealprof opened this issue Nov 19, 2019 · 3 comments

Comments

@therealprof
Copy link
Contributor

As noticed when trying to change embedded-hal to edition 2018, a number of examples using the nb::await! macro fail to compile: rust-embedded/embedded-hal#167

However async/await is currently not available in no_std due to the implicit use of TLS.

Can we come up with some workaround might would us to unbreak the use of the primitives provided by this crate or should we leave nb unchanged and remove the offending examples until async/await becomes usable?

cc @japaric
cc @Nemo157
cc @no111u3

@no111u3
Copy link

no111u3 commented Nov 19, 2019

I updated review and temporary fixed problems with nb but it doesn't sounds good - It looks like a hack: r# prefixes wouldn’t be an ergonomic solution that users are familiar with.

@no111u3
Copy link

no111u3 commented Nov 27, 2019

Initial review was merged. Now I have some solution - replace everything of nb use to core::task::Poll: rust-embedded/embedded-hal#171. But I have no solution to change nb package as crate.

@therealprof
Copy link
Contributor Author

I think we can close this for now. For async/await we'll come up with a different plan an we're going to keep this as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants