-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfcs: add move_itm_crate #589
Conversation
Thank you for the RFC. I'd be happy move ahead with this, but let's hear from the other @rust-embedded/tools members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just linking the voting rules here: https://github.com/rust-embedded/wg/blob/master/rfcs/0206-voting-majority.md. The team is: |
The I'll review this once I'm home later this evening. |
Oops. That is unexpected ... but correct. |
For sake of transparency: if and when this goes though the repository will be moved to https://github.com/rtic-scope/itm (updated repo already available; so only the crates.io registery entry is necessary at this point) because of its design towards RTIC Scope. I'll amend the RFC if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight preference to not abandon itm
and rather encourage its development by new contributors inside the WG, but a stronger preference that it gets developed at all, so on balance I'm in favour here. I look forward to welcoming the crate back one day!
@thalesfragoso, any thoughts?
Sorry for taking too long, I've been a bit busy... Anyways, isn't it better to just move ownership of the crate's name and archive I would also like that a new published version of Thanks for the work @tmplt and sorry for being a drag... |
A |
I'd be fine with this approach too, I guess you're right and there might not be much point transferring this repo only to merge a PR that essentially replaces all the code. We could archive this one for reference in the future and just allow the new crate to be published as a semver-incompatible version on top. What do you think @tmplt?
I don't think there's any need to pull them. It won't do anything to current users anyway, and it's not like there's some security issue in the older versions. |
Sounds good to me. But what is a semver-incompatible version? A release above |
Yes, 0.4.0 would be fine. |
Should the RFC be amended with the following:
|
Clarifying what
It's already there (twice), no? https://github.com/rust-embedded/wg/pull/589/files#diff-6b7ea2d7569e31f5da361fe6f319517f068bbc9f38b5b5ef69700b196caebaf2R9 |
Co-authored-by: Daniel Egger <[email protected]>
130c1c2
RFC amended: it now proposes archiving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As approved by the team and discussed in the meeting today, this is good to go and will be put in effect immediately.
Thanks @tmplt.
bors r+
Build succeeded: |
As discussed in the Matrix chat (from 2021-11-31--2021-12-01) here is an RFC proposing the disown/move of the
itm
crate and repo for continued development outside of the WG.Rendered RFC