Fix test failure in changing_bin_features_caches_targets for Linux. #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang/rust#50962. My theory is that while copying the binary, another thread forked with the fd open. The copy finishes and attempts to exec before the other child execs (and closes the writeable fd). I was able to easily repro this on linux. I ran some stress tests of this fix locally on linux and on appveyor, and was unable to trigger it again.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Thanks for tracking this down! |
|
📌 Commit 83e87d4 has been approved by |
bors
added a commit
that referenced
this pull request
May 22, 2018
Fix test failure in changing_bin_features_caches_targets for Linux. Fixes rust-lang/rust#50962. My theory is that while copying the binary, another thread forked with the fd open. The copy finishes and attempts to exec before the other child execs (and closes the writeable fd). I was able to easily repro this on linux. I ran some stress tests of this fix locally on linux and on appveyor, and was unable to trigger it again.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#50962.
My theory is that while copying the binary, another thread forked with the fd
open. The copy finishes and attempts to exec before the other child execs (and
closes the writeable fd).
I was able to easily repro this on linux. I ran some stress tests of this fix
locally on linux and on appveyor, and was unable to trigger it again.