Don't set CMAKE_SYSTEM_NAME=Linux #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
approved these changes
Jan 5, 2022
messense
approved these changes
Jan 5, 2022
|
Is there any confidence that this is the right fix? I don't know why cross-compiling would somehow be different than not. If there's not confidence that this is the right fix then I'd prefer that this would be reverted for now. |
Previously, this would set SYSTEM_NAME unconditionally whenever targeting Linux. Unfortunately, Cmake unsets some other variables when SYSTEM_NAME is set; in particular `CMAKE_SYSTEM_VERSION` and `CMAKE_SYSTEM_PROCESSOR`. To avoid regressing other builds, this reverts the change; builds which want to cross-compile to linux can set `SYSTEM_NAME` themselves.
jyn514
force-pushed
the
cmake-system-name
branch
from
8a87b7a to
f625e2c
Compare
|
No, I'm fine with reverting, I was just trying to keep the churn low. I changed this PR to be a straight revert instead. |
jyn514
changed the title
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would set SYSTEM_NAME unconditionally whenever targeting Linux.
Unfortunately, Cmake unsets some other variables when SYSTEM_NAME is set;
in particular
CMAKE_SYSTEM_VERSIONandCMAKE_SYSTEM_PROCESSOR.To avoid regressing other builds, this reverts the change; builds which
want to cross-compile to linux can set
SYSTEM_NAMEthemselves.Fixes #138 (I confirmed locally that this fixes the build for boring-sys).