Fixes #55 #1095
Closed
Fixes #55 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rust-lang#55 while avoiding the mistake of placing the router_handler after the database_file_handler which acts differently in test and prod (rust-lang#1051).
|
Hmm, there is another PR open that also fixes the issue and cleans up some other issues at the same time. I think I'd rather have that one: #1090 |
|
Re-opening since I misunderstood the other PR (sorry!) |
jyn514
added
hacktoberfest
|
You still need to rebase though, because this part of the codebase changed significantly in #1090 and I expect you might need to make changes for the tests to pass. |
jyn514
added
S-waiting-on-author
|
friendly ping @robinhundt :) are you still interested in making this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #55 while avoiding the mistake of placing the router_handler
after the database_file_handler which acts differently in test and prod
(#1051).
However the order of the handler is changed again,
router_handleris now the first. I can't confidently say that this change doesn't have some unintended side effects again.