The "Efficient method" and "Beginner friendly method" seem essentially the same here.

[woofyzhao]

https://doc.rust-lang.org/rust-by-example/std_misc/file/read_lines.html

They are actually the same except that the "Efficient method" wraps the Lines object in a Result...

[woofyzhao]

@frittex14 Please take a look at this. It does not seem to have anything to do with efficiency.

[frittex14]

Hey,
The reason for this change was to give Rust beginners code that's simple to understand. I use 'efficient' here to mean things like good code organization, readability, and being in line with how Rust is usually written, not how fast it runs. If it's bugging you, you can change it to "This method is NOT idiomatic." or something similar, but I still reckon using 'efficient' makes it easiest to explain to someone new to Rust, or programming in general. Hope this helps ;)

[woofyzhao]

Hey, The reason for this change was to give Rust beginners code that's simple to understand. I use 'efficient' here to mean things like good code organization, readability, and being in line with how Rust is usually written, not how fast it runs. If it's bugging you, you can change it to "This method is NOT idiomatic." or something similar, but I still reckon using 'efficient' makes it easiest to explain to someone new to Rust, or programming in general. Hope this helps ;)

Oh, then it's the bottom line "This process is more efficient than creating a String in memory especially working with larger files." that made me confused.

Thank you for your explanation.