needless_collect: spans are off by one

[matthiaskrgr]

warning: avoid using `collect()` when not needed
   --> src/clean_unref.rs:214:86
    |
214 |     let required_crates: Vec<_> = required_crates.into_iter().map(SourceKind::inner).collect();
    |                                   ---------------------------                        ^^^^^^^
    |                                   |
    |                                   the iterator could be used here instead
    |
note: the lint level is defined here
   --> src/main.rs:29:5
    |
29  |     clippy::perf,
    |     ^^^^^^^^^^^^
    = note: `#[warn(clippy::needless_collect)]` implied by `#[warn(clippy::perf)]`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
help: use the original Iterator instead of collecting it and then producing a new one
    |
214 |     required_crates.into_iter().map(SourceKind::inner).map(SourceKind::inner).collect();
    |    --                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Looks like the spans are a bit off in the lower message?
I'm not sure if this is a clippy lint bug or a rustc diasgnostics bug.

[camsteffen]

Do you have a reproducible example?

[matthiaskrgr]

Ok I just saw, what is seven more strange is that the lint suggestion duplicates the .map() call in the suggestion. o.O

.map(SourceKind::inner) in the original code, required_crates.into_iter().map(SourceKind::inner).map(SourceKind::inner).collect(); in the suggested code..??!

[matthiaskrgr]

Here's stand alone repro of the strange spans:

use std::path::PathBuf;

fn main() {
    let required_crates = vec![];
    let required_crates: Vec<_> = required_crates.into_iter().collect();

    let _ = vec![1, 2, 3]
        .iter()
        .filter(|x| !required_crates.contains(&PathBuf::new()));
}

warning: avoid using `collect()` when not needed
 --> src/main.rs:5:63
  |
5 |     let required_crates: Vec<_> = required_crates.into_iter().collect();
  |                                   --------------------------- ^^^^^^^
  |                                   |
  |                                   the iterator could be used here instead
  |
  = note: `#[warn(clippy::needless_collect)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
help: use the original Iterator instead of collecting it and then producing a new one
  |
5 |     required_crates.into_iter().collect();
  |    --                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^

there's really something odd with these spans :D