Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary_join documentation update #8640

Closed
wants to merge 0 commits into from
Closed

unnecessary_join documentation update #8640

wants to merge 0 commits into from

Conversation

yoav-lavi
Copy link
Contributor

changelog: none

Updates the description of unnecessary_join in accordance with #8579 (comment). I've also added a line regarding differences in assembly output, please let me know if it should also make it in.

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 6, 2022
@yoav-lavi
Copy link
Contributor Author

r? @flip1995

@rust-highfive rust-highfive assigned flip1995 and unassigned xFrednet Apr 6, 2022
@flip1995
Copy link
Member

flip1995 commented Apr 6, 2022

Also answering your question from the other PR: I think having this in pedantic is fine. I don't think the performance impact is that big in cases where the collect+join is faster.

Please squash the commits and we can merge this.

@yoav-lavi yoav-lavi closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants