-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synch libuv submodule to joyent/libuv, tag 0.11.14 #10246
Comments
I'm currently waiting on one pull request to go through with libuv (979 on their end), and then after that I was planning on syncing directly to joyent/libuv instead of my fork. It would be awesome to use an external libuv! Detecting a version (b/c we have a minimum requirement) may get interesting, but it's great that we're at least in this position! |
I didn't see your PR, I'll probably wait for the next libuv tag then. For version detection, I'm currently shipping a pkg-config file for libuv in Debian which I'm going to push upstream soon. This can be used at least for unix, not sure about win and mac. |
my pull request in libuv has landed, I'd ideally like to wait for #10321 to land before tackling this, but it may take awhile. |
At this time, also point the libuv submodule to the official repo instead of my own off to the side. Closes rust-lang#10246
At this time, also point the libuv submodule to the official repo instead of my own off to the side. cc rust-lang#10246 Closes rust-lang#10329
I was going to close this, but it turns out that we still need alexcrichton/libuv@7ac7e02 or otherwise we'll just infinite loop during the build process. The corresponding libuv issue is joyent/libuv#909. Until that gets fixed in master, it looks like we won't be able to use libuv master. |
Closing, we're on libuv 0.11.25 except for one small patch to fix the build on android, so this is basically done. |
As part of the ongoing effort to reduce rust-specific patches and thanks (a lot!) to @alexcrichton, we have now reached the point where we can use vanilla libuv.
As such, I'd like to propose several changes to current submodule tracking:
However, let's remind that we jumped on the 0.11.x branch but its API is not yet stable, so breakage may still occur before reaching 0.12.x.
This is prerequisite to #5563, which I'll probably tackle after this (proposed) synch.
The text was updated successfully, but these errors were encountered: