Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run any run-make test without checking out the cargo submodule #135573

Closed
RalfJung opened this issue Jan 16, 2025 · 2 comments
Closed

Cannot run any run-make test without checking out the cargo submodule #135573

RalfJung opened this issue Jan 16, 2025 · 2 comments
Labels
A-run-make Area: port run-make Makefiles to rmake.rs C-discussion Category: Discussion or questions that doesn't represent real issues.

Comments

@RalfJung
Copy link
Member

I generally want to have as few git submodule checked out as possible in the rustc repo, since all the checked out submodules need to be synced each time they change and I'd like to minimize the number of time I have to run git submodule update --recursive. Therefore, I do not have the cargo submodule checked out.

However, this means I cannot run ./x test run-make. My understanding is that some run-make tests need cargo, but most do not, so it is unfortunate that I cannot run the non-cargo-using run-make tests without checking out cargo. Would be nice to check this in the test rather than blanket rejecting the entire test suite when cargo is missing.

(Also maybe one could use bootstrap cargo instead of the submodule? But I assume there's a reason the submodule is used so this probably does not work.)

Cc @jieyouxu

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 16, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 16, 2025

A couple tests were using BOOTSTRAP_CARGO with -Zbuild-std, but that
stage0 cargo might not always be in sync with in-tree changes. In
particular, those tests started failing on the beta branch because the
older cargo couldn't find the library Cargo.lock, and then couldn't
build the latest version of compiler_builtins that had nightly changes.

@jieyouxu jieyouxu added C-discussion Category: Discussion or questions that doesn't represent real issues. A-run-make Area: port run-make Makefiles to rmake.rs and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 16, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 16, 2025

I'm going to close this in favor of #134109, but I do appreciate that this is annoying, and is something I'd like to look into towards end of this month or early next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs C-discussion Category: Discussion or questions that doesn't represent real issues.
Projects
None yet
Development

No branches or pull requests

3 participants