Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly keep an array sorted instead of sorting-all-at-once in gather_anti_quotes #2250

Closed
catamorphism opened this issue Apr 19, 2012 · 1 comment
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

From a FIXME in syntax::ext::qquote: "Maybe this is an overkill (merge_sort), it might be better to just keep the gather array in sorted order ..."

I'm suspecting that the arrays in question might not ever be large enough for it to make a difference in performance anyway. But I guess someone might want to do a comparison.

@graydon
Copy link
Contributor

graydon commented Mar 12, 2013

No longer relevant, closing.

@graydon graydon closed this as completed Mar 12, 2013
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
Require local annotations for local diagnostics

if/when we get flaky diagnostics we can revisit and add more helpers for those
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
BoxyUwU pushed a commit to BoxyUwU/rust that referenced this issue Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants