Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md confusing sentence in msys2 for Windows #36115

Closed
barik opened this issue Aug 29, 2016 · 4 comments
Closed

README.md confusing sentence in msys2 for Windows #36115

barik opened this issue Aug 29, 2016 · 4 comments
Labels
O-windows Operating system: Windows

Comments

@barik
Copy link
Contributor

barik commented Aug 29, 2016

The last sentence says:

# or CMake installed and in PATH you can remove them from this list. Note
# that it is important that the `python2` and `cmake` packages **not** used.
# The build has historically been known to fail with these packages.

I'm unclear on the sentence starting with Note. The sentence seems to be missing a verb: are not used? But if that is true, it looks like the pacman command below wants to install them anyway.

@steveklabnik steveklabnik added A-docs O-windows Operating system: Windows labels Aug 29, 2016
@frewsxcv
Copy link
Member

cc @alexcrichton who wrote these sentences. The description in the commit message also seems relevant to this Issue. I don't know much about MSYS2, but it looks like it might be the case that there exists a python2 package, but it shouldn't be used. Instead, one should install mingw-w64-x86_64-python2.

@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 17, 2016

Yep, python2 and mingw-w64-x86_64-python2 are different packages.
MSYS2 has three subsystems/environments with separate sets of packages - msys2, mingw32 and mingw64 (more about them here).
Rust is usually built in mingw64 environment (or mingw32; msys2 is used for development of MSYS2 itself) and has to use mingw64 version of Python.

(Curiously, mingw-w64-x86_64-make fails trying to build Rust (at least it did the last time I tried it), so make from msys2 environment has to be used. Also mingw-w64-x86_64-python2 and mingw-w64-x86_64-gdb have completely broken interactive shell unlike python2 and gdb, so you have to deal with all subsystems anyway sooner or later :D)

@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 17, 2016

@barik
Does my answer resolves the issue (modulo the missing verb)?
I'm not sure all these technicalities need to be put into README.

EDIT: Oh, the question was asked on Aug 29, it probably doesn't matter now.

@barik
Copy link
Contributor Author

barik commented Dec 18, 2016

@petrochenkov Thanks, yes that resolves the issue. I guess when reading it originally, I didn't realize python2 was actually referring to a package in the MSYS ecosystem. Wonder if something like the following would help clarify for future readers, without having to get into too many technicalities:

Note that it is important that you do not use the python2 and cmake packages from the msys2 subsystem. The build has historically been known to fail with these packages.

frewsxcv added a commit to frewsxcv/rust that referenced this issue Dec 21, 2016
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 30, 2016
…, r=alexcrichton

Clarify phrasing of MSYS2 dependencies in README.md.

Fixes rust-lang#36115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

4 participants