Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider whether ? should switch from From::from to Into::into for Rust 2018 #49531

Closed
scottmcm opened this issue Mar 31, 2018 · 2 comments
Closed

Consider whether ? should switch from From::from to Into::into for Rust 2018 #49531

scottmcm opened this issue Mar 31, 2018 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. WG-epoch Working group: Epoch (2018) management

Comments

@scottmcm
Copy link
Member

Using into instead allows for more conversions to be defined, since it has different coherence rules, which all else being equal would be good. But because of that, there are (per the IRLO thread) some uses that are inferable today with from but not into.
@scottmcm scottmcm added C-enhancement Category: An issue proposing an enhancement or a PR with one. WG-epoch Working group: Epoch (2018) management labels Mar 31, 2018
@varkor
Copy link
Member

varkor commented Dec 21, 2018

Rust 2018 has since been released, so I imagine this issue can now be closed?

@scottmcm
Copy link
Member Author

scottmcm commented Jun 9, 2021

This didn't happen in 2018, and rust-lang/rfcs#3058 moved to a system where this is no longer easily doable on an edition boundary, so closing.

@scottmcm scottmcm closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. WG-epoch Working group: Epoch (2018) management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varkor @scottmcm