Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayu theme code color is off in stable rustdoc #87828

Closed
Cldfire opened this issue Aug 6, 2021 · 1 comment · Fixed by #87861
Closed

Ayu theme code color is off in stable rustdoc #87828

Cldfire opened this issue Aug 6, 2021 · 1 comment · Fixed by #87861
Assignees
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Cldfire
Copy link
Contributor

Cldfire commented Aug 6, 2021

Rustdoc back in 1.48.0: https://doc.rust-lang.org/1.48.0/std/io/struct.BufReader.html#method.new

Screen Shot 2021-08-06 at 2 39 37 PM

Rustdoc today on stable: https://doc.rust-lang.org/stable/std/io/struct.BufReader.html#method.new

Screen Shot 2021-08-06 at 2 39 58 PM

Note how the code color has gone from a soft white to a hard white, making Ayu more glaring and less enjoyable to read.

Looking at the HTML in 1.48.0:

Screen Shot 2021-08-06 at 2 40 49 PM

It got changed at some point, current stable:

Screen Shot 2021-08-06 at 2 41 11 PM

The CSS rule that's supposed to be applying here is:

Screen Shot 2021-08-06 at 2 41 27 PM

So that will need to be adjusted for the HTML change.

I'm not going to have time to fix this for at least a couple of weeks, so if someone else has the time to submit a PR for this, please do 🙂.

@inquisitivecrystal inquisitivecrystal added A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 6, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 6, 2021
@tsoutsman
Copy link
Contributor

@rustbot claim

JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 10, 2021
Fix heading colours in Ayu theme

Closes rust-lang#87828
The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 10, 2021
Fix heading colours in Ayu theme

Closes rust-lang#87828
The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 10, 2021
Fix heading colours in Ayu theme

Closes rust-lang#87828
The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
@bors bors closed this as completed in 9a78489 Aug 11, 2021
@JohnTitor JohnTitor removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants