Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RustcInternal for RawPtrKind #136590

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Implement RustcInternal for RawPtrKind #136590

merged 1 commit into from
Feb 6, 2025

Conversation

carolynzech
Copy link
Contributor

Implement RustcInternal for RawPtrKind. #135748 introduced a Stable implementation here.

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2025
@carolynzech carolynzech mentioned this pull request Feb 5, 2025
Closed
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 5, 2025

📌 Commit 3b54fab has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025
@workingjubilee workingjubilee mentioned this pull request Feb 6, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
@bors
Auto merge of rust-lang#136613 - workingjubilee:rollup-ry6rw0m, r=wor…
5958825 
…kingjubilee

Rollup of 13 pull requests

Successful merges:

 - rust-lang#133932 (Avoid using make_direct_deprecated() in extern "ptx-kernel")
 - rust-lang#136269 (Pass spans around new solver)
 - rust-lang#136550 (Fix `rustc_hidden_type_of_opaques` for RPITITs with no default body)
 - rust-lang#136558 (Document minimum supported host tooling on macOS)
 - rust-lang#136563 (Clean up `Trivial*Impls` macros)
 - rust-lang#136566 (Fix link in from_fn.rs)
 - rust-lang#136573 (Document why some "type mismatches" exist)
 - rust-lang#136583 (Only highlight unmatchable parameters at the definition site)
 - rust-lang#136587 (Update browser-ui-test version to `0.20.2`)
 - rust-lang#136590 (Implement RustcInternal for RawPtrKind)
 - rust-lang#136591 (Add `rustc_hir_pretty::expr_to_string` function)
 - rust-lang#136595 (Fix `unreachable_pub` lint for hermit target)
 - rust-lang#136611 (cg_llvm: Remove the `mod llvm_` hack, which should no longer be necessary)

Failed merges:

 - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a9d4b01 into rust-lang:master Feb 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
@rust-timer
Unrolled build for rust-lang#136590
45400bc 
Rollup merge of rust-lang#136590 - carolynzech:raw-ptr-kind-internal, r=compiler-errors

Implement RustcInternal for RawPtrKind

Implement `RustcInternal` for `RawPtrKind`. rust-lang#135748 introduced a `Stable` implementation [here](https://github.com/rust-lang/rust/pull/135748/files#diff-60f5e8edf69e04e89ef0c7f576363a91fa141e1db969484cef00063ed39c62e4R235).
@carolynzech carolynzech deleted the raw-ptr-kind-internal branch February 7, 2025 18:02
carolynzech added a commit to carolynzech/kani that referenced this pull request Feb 10, 2025
@carolynzech
Update toolchain to 1/29
1c0db81 
- RValue::RawRef changes, c.f. rust-lang/rust#135748 and rust-lang/rust#136590
carolynzech added a commit to carolynzech/kani that referenced this pull request Feb 10, 2025
@carolynzech
Update toolchain to 2/7
6520265 
  - Implement internal for RawPtrKind, c.f. rust-lang/rust#136590
  - Replace Lrc with Arc, c.f. rust-lang/rust#136471
@carolynzech carolynzech mentioned this pull request Feb 10, 2025
Merged
carolynzech added a commit to carolynzech/kani that referenced this pull request Feb 10, 2025
@carolynzech
Update toolchain to 2/7
4cb50ee 
  - Implement internal for RawPtrKind, c.f. rust-lang/rust#136590
  - Replace Lrc with Arc, c.f. rust-lang/rust#136471
github-merge-queue bot pushed a commit to model-checking/kani that referenced this pull request Feb 11, 2025
@carolynzech
Upgrade toolchain to 2/10 (#3883)
81e9aa3 
Upgrade toolchain to 2/10.

I **highly recommend** reviewing this PR commit-by-commit. The
description in each commit message links to the upstream PRs that
prompted those particular changes.

## Callouts
- 2/1 had a lot of formatting changes. I split the commits for that day
into formatting changes and functionality changes accordingly.
- 2/5 introduced a regression in our delayed UB instrumentation, so I
made a new fixme test. See #3881 for details.


## Culprit PRs:
rust-lang/rust#134424 
rust-lang/rust#130514
rust-lang/rust#135748
rust-lang/rust#136590
rust-lang/rust#135318
rust-lang/rust#135265

rust-lang/rust@bcb8565
rust-lang/rust#136471
rust-lang/rust#136645

Resolves #3863

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carolynzech @rustbot @compiler-errors @bors @oli-obk