Rollup of 6 pull requests #136804

Zalathar · 2025-02-10T07:07:15Z

Successful merges:

Add Four Codegen Tests #134626 (Add Four Codegen Tests)
coverage: Defer part of counter-creation until codegen #136053 (coverage: Defer part of counter-creation until codegen)
Simplify Rc::as_ptr docs + typo fix #136228 (Simplify Rc::as_ptr docs + typo fix)
ci: stop mysql before removing it #136487 (ci: stop mysql before removing it)
Git blame ignore recent formatting commit #136790 (Git blame ignore recent formatting commit)
Subtree update of rust-analyzer #136803 (Subtree update of rust-analyzer)

r? @ghost
@rustbot modify labels: rollup

Split manual.adoc into markdown files, one for each chapter. For the parts of the manual that are generated from source code doc comments, update the comments to use markdown syntax and update the code generators to write to `generated.md` files. For the weekly release, stop copying the .adoc files to the `rust-analyzer/rust-analyzer.github.io` at release time. Instead, we'll sync the manual hourly from this repository. See rust-analyzer/rust-analyzer.github.io#226 for the sync. This PR should be merged first, and that PR needs to be merged before the next weekly release. This change is based on rust-lang#15795, but rebased and updated. I've also manually checked each page for markdown syntax issues and fixed any I encountered. Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Josh Rotenberg <[email protected]>

… not inside a macro call anymore) *after* the recursive call instead of before it This is because our detection is imperfect, and miss some cases such as an impersonating `test` macro, so we hope we'll expand successfully in this case.

AKA. target_feature 1.1, or non unsafe target_feature.

feat: Support RFC 2396

fix: In completion's expand, consider recursion stop condition (when we're not inside a macro call anymore) *after* the recursive call instead of before it

Split out `ExpressionStore` from `Body`

…lues feat: Implement `default-field-values`

It should be considered by the edition of the caller, not the callee. Technically we still don't do it correctly - we need the span of the method name (if it comes from a macro), but we don't keep it and this is good enough for now.

That was used as a fallback, causing a panic when the fallback was chosen. I also made sure this won't happen again by guaranteeing in the macro generating the tokens that they all exist.

fix: Fix a missing standard token in semantic highlighting

fix: Fix #[rustc_deprecated_safe_2024]

fix: Fix syntactic highlighting for renames

I added it by mistake in rust-lang#18927. I chose to keep the method as not static, because it's more comfortable, and keep the name `add_reference()` and not `reference()`, because it is clearer and better matches `strip_reference[s]()`.

bors · 2025-02-10T08:14:37Z

⌛ Testing commit 1417031 with merge 9eea580...

Rollup of 6 pull requests Successful merges: - rust-lang#134626 (Add Four Codegen Tests) - rust-lang#136053 (coverage: Defer part of counter-creation until codegen) - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix) - rust-lang#136487 (ci: stop mysql before removing it) - rust-lang#136790 (Git blame ignore recent formatting commit) - rust-lang#136803 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-02-10T08:27:51Z

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[1403/3594] Building AMDGPUGenAsmWriter.inc...
[1404/3594] Building AMDGPUGenAsmMatcher.inc...
[1405/3594] Building AMDGPUGenDAGISel.inc...
[1406/3594] Building AMDGPUGenDisassemblerTables.inc...
FAILED: lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc 
cd /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build && /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-disassembler -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU/AMDGPU.td --write-if-changed -o lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc -d lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc.d
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-disassembler -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU/AMDGPU.td --write-if-changed -o lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc -d lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc.d
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  llvm-tblgen              0x00000001049695b7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1  llvm-tblgen              0x00000001049677a8 llvm::sys::RunSignalHandlers() + 248
2  llvm-tblgen              0x0000000104969c50 SignalHandler(int) + 272
3  libsystem_platform.dylib 0x00007ff8089885ed _sigtramp + 29
4  libsystem_malloc.dylib   0x00007ff808796f81 tiny_free_detach_region + 313
5  libsystem_c.dylib        0x00007ff808881b45 abort + 123
6  libsystem_malloc.dylib   0x00007ff808798752 malloc_vreport + 888
7  libsystem_malloc.dylib   0x00007ff80879bb31 malloc_report + 151
8  llvm-tblgen              0x00000001047242d9 llvm::Record::~Record() + 153
9  llvm-tblgen              0x000000010498bd6f std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 63
10 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
11 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
12 llvm-tblgen              0x000000010498bd4a std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 26
13 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
14 llvm-tblgen              0x000000010498bd4a std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 26
15 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
16 llvm-tblgen              0x000000010498bd4a std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 26
17 llvm-tblgen              0x000000010498bd4a std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 26
18 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
19 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
20 llvm-tblgen              0x000000010498bd56 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, std::__1::less<void>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::Record, std::__1::default_delete<llvm::Record>>>, void*>*) + 38
21 llvm-tblgen              0x0000000104984a6a llvm::RecordKeeper::~RecordKeeper() + 202
22 llvm-tblgen              0x000000010497049a llvm::TableGenMain(char const*, std::__1::function<bool (llvm::raw_ostream&, llvm::RecordKeeper&)>) + 3754
23 llvm-tblgen              0x000000010490aaf4 main + 148
24 dyld                     0x00007ff808600418 start + 1896
/bin/sh: line 1: 22317 Abort trap: 6           /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-disassembler -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/AMDGPU/AMDGPU.td --write-if-changed -o lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc -d lib/Target/AMDGPU/AMDGPUGenDisassemblerTables.inc.d
[1408/3594] Building AMDGPUGenGlobalISel.inc...
[1409/3594] Building AMDGPUGenInstrInfo.inc...
ninja: build stopped: subcommand failed.

bors · 2025-02-10T08:28:28Z

💔 Test failed - checks-actions

workingjubilee · 2025-02-10T08:40:25Z

what?

jieyouxu · 2025-02-10T08:41:28Z

Spurious (but likely an actual upstream bug or our bug), #109624

workingjubilee · 2025-02-10T08:43:35Z

@bors retry

Zalathar · 2025-02-10T08:45:05Z

Bors has moved on to the r-a update (which is in this rollup), so better to close in this case.

@bors r-

bors · 2025-02-10T08:45:32Z

⌛ Testing commit 1417031 with merge f072cf0...

Rollup of 6 pull requests Successful merges: - rust-lang#134626 (Add Four Codegen Tests) - rust-lang#136053 (coverage: Defer part of counter-creation until codegen) - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix) - rust-lang#136487 (ci: stop mysql before removing it) - rust-lang#136790 (Git blame ignore recent formatting commit) - rust-lang#136803 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2025-02-10T08:46:27Z

@bors r-

Zalathar · 2025-02-11T02:27:44Z

@bors r-

Zalathar · 2025-02-11T02:33:54Z

@bors retry

(Trying to poke bors into being less confused without a full resync.)

fmease · 2025-02-17T02:11:53Z

@bors retry r- (still in the queue (unapproved ofc))

vishruth-thimmaiah and others added 30 commits January 20, 2025 19:46

fix: upmap ranges in convert_tuple_struct_to_named_struct assist

a8f5471

fixes rust-lang#18766

Combine pat_hyigene and expr_hygiene

b46775a

BodyCollector

8e7a338

Cleanup body ast ptr defs

d9c58c8

Split out ExpressionStore from Body

c679d56

Add GenericDefId::StaticId

bdebd86

Support RFC 2396

5de2cd4

AKA. target_feature 1.1, or non unsafe target_feature.

Merge pull request rust-lang#19038 from ChayimFriedman2/unused-unsafe

9051647

feat: Support RFC 2396

Merge pull request rust-lang#19037 from ChayimFriedman2/fix-other-test

6db1411

fix: In completion's expand, consider recursion stop condition (when we're not inside a macro call anymore) *after* the recursive call instead of before it

Merge pull request rust-lang#19036 from Veykril/push-nprltlwvryxw

1711a19

Split out `ExpressionStore` from `Body`

feat: Implement default-field-values

d18afd3

Handle missing fields diagnostics

5ca9f52

Merge record lit's ellipsis into pre-existing spread's variant

2622160

Compute diagnostics of a field body iff it has one

faeaf4a

Implement HasResolver and HasModule for FieldId

c7463fe

Add a test for field default value body as defining usage of TAIT

ec89b7d

Fix a mistake in condition

e4e7c95

Remove has_default from FieldId

c093db0

Merge pull request rust-lang#19001 from ShoyuVanilla/default-field-va…

ad0aea4

…lues feat: Implement `default-field-values`

Fix #[rustc_deprecated_safe_2024]

9a0504b

It should be considered by the edition of the caller, not the callee. Technically we still don't do it correctly - we need the span of the method name (if it comes from a macro), but we don't keep it and this is good enough for now.

Fix a missing standard token in semantic highlighting

86d5e29

That was used as a fallback, causing a panic when the fallback was chosen. I also made sure this won't happen again by guaranteeing in the macro generating the tokens that they all exist.

Merge pull request rust-lang#19045 from ChayimFriedman2/missing-token

238d7bd

fix: Fix a missing standard token in semantic highlighting

Merge pull request rust-lang#19044 from ChayimFriedman2/deprecated-safe

0fe9d77

fix: Fix #[rustc_deprecated_safe_2024]

Fix syntactic highlighting for renames

5f2072c

Merge pull request rust-lang#19047 from lnicola/rename-highlight

d60afec

fix: Fix syntactic highlighting for renames

Remove duplicate method from hir::Type

78feee8

I added it by mistake in rust-lang#18927. I chose to keep the method as not static, because it's more comfortable, and keep the name `add_reference()` and not `reference()`, because it is clearer and better matches `strip_reference[s]()`.

Don't suggest into_iter().method() on iterators

b4508dc

Report calling unsafe fn pointer as unsafe

1ba8943

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 10, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2025

Zalathar closed this Feb 10, 2025

Zalathar deleted the rollup-o3nyapl branch February 10, 2025 08:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2025

workingjubilee removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 14, 2025

fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #136804

Rollup of 6 pull requests #136804

Zalathar commented Feb 10, 2025

bors commented Feb 10, 2025

rust-log-analyzer commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

jieyouxu commented Feb 10, 2025 •

edited

Loading

workingjubilee commented Feb 10, 2025

Zalathar commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

Zalathar commented Feb 11, 2025

Zalathar commented Feb 11, 2025

fmease commented Feb 17, 2025

Rollup of 6 pull requests #136804

Rollup of 6 pull requests #136804

Conversation

Zalathar commented Feb 10, 2025

bors commented Feb 10, 2025

rust-log-analyzer commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

jieyouxu commented Feb 10, 2025 • edited Loading

workingjubilee commented Feb 10, 2025

Zalathar commented Feb 10, 2025

bors commented Feb 10, 2025

workingjubilee commented Feb 10, 2025

Zalathar commented Feb 11, 2025

Zalathar commented Feb 11, 2025

fmease commented Feb 17, 2025

jieyouxu commented Feb 10, 2025 •

edited

Loading