Update host LLVM to 20.1 on CI #137189

Kobzol · 2025-02-17T19:58:44Z

r? @ghost

Kobzol · 2025-02-17T19:58:49Z

@bors try @rust-timer queue

Update host LLVM to 20.1 on CI r? `@ghost`

bors · 2025-02-17T20:00:00Z

⌛ Trying commit 28d589c with merge bf1902f...

bors · 2025-02-17T22:36:17Z

☀️ Try build successful - checks-actions
Build commit: bf1902f (bf1902f3496523d29702dc2fccacd5661277cd33)

rust-timer · 2025-02-18T02:29:58Z

Finished benchmarking commit (bf1902f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	4
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	-0.2%	[-0.3%, 0.1%]	5

Max RSS (memory usage)

Results (secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 774.698s -> 771.5s (-0.41%)
Artifact size: 362.37 MiB -> 361.04 MiB (-0.37%)

Kobzol · 2025-02-18T06:13:33Z

Interesting, usually there are more perf. effects.

r? @nikic

(Let me know if you want to wait for the final release, last time we kind of forget and stayed on RC the whole time 😆)

nikic · 2025-02-18T11:38:29Z

Staying on an rc for the host compiler isn't really a problem...

@bors r+

bors · 2025-02-18T11:38:31Z

📌 Commit 28d589c has been approved by nikic

It is now in the queue for this repository.

bors · 2025-02-20T16:35:23Z

⌛ Testing commit 28d589c with merge 49bca9a...

Update host LLVM to 20.1 on CI r? `@ghost`

rust-log-analyzer · 2025-02-20T18:18:46Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] tests\ui\panic-runtime\transitive-link-a-bunch.rs stdout ----

error: auxiliary build of "D:\\a\\rust\\rust\\tests\\ui\\panic-runtime\\auxiliary\\panic-runtime-abort.rs" failed to compile: 
status: exit code: 1
command: PATH="D:\a\rust\rust\build\i686-pc-windows-msvc\stage2\bin;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x86;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0-bootstrap-tools\i686-pc-windows-msvc\release\deps;D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX64\x86" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\ui\\panic-runtime\\auxiliary\\panic-runtime-abort.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2" "--target=i686-pc-windows-msvc" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\ui\\panic-runtime\\transitive-link-a-bunch\\auxiliary" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "-C" "panic=abort" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\ui\\panic-runtime\\transitive-link-a-bunch\\auxiliary"
--- stderr -------------------------------
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcNCqAau"
error: aborting due to 1 previous error
------------------------------------------


---
test result: FAILED. 18206 passed; 1 failed; 371 ignored; 0 measured; 23 filtered out; finished in 1162.52s

Some tests failed in compiletest suite=ui mode=ui host=i686-pc-windows-msvc target=i686-pc-windows-msvc
Build completed unsuccessfully in 1:37:35
make: *** [Makefile:111: ci-msvc-py] Error 1
  network time: Thu, 20 Feb 2025 18:18:32 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-02-20T18:19:31Z

💔 Test failed - checks-actions

Kobzol · 2025-02-20T22:33:40Z

Sounds spurious.

@bors retry

Update host LLVM to 20.1 on CI r? `@ghost`

bors · 2025-02-21T03:24:41Z

⌛ Testing commit 28d589c with merge 29656bd...

bors · 2025-02-21T09:24:41Z

💥 Test timed out

rust-log-analyzer · 2025-02-21T09:25:41Z

The job dist-i686-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#19 3769.7 ./build-gcc.sh: line 48: 416258 Terminated              bash -c "while true; do sleep 30; echo \$(date) - building ...; done"
#19 3769.7 + cd ..
#19 3769.7 + rm -rf gcc-build
#19 3771.9 + rm -rf gcc-9.5.0
#19 3775.2 + [[ i686-pc-linux-gnu == \i\6\8\6\-\p\c\-\l\i\n\u\x\-\g\n\u ]]
#19 3775.5 Loaded plugins: ovl
#19 3775.6 Resolving Dependencies
#19 3775.6 --> Running transaction check
#19 3775.6 ---> Package gcc.x86_64 0:4.8.5-44.el7 will be erased
---
#23 33.75 + mkdir clang-build
#23 33.75 + cd clang-build
#23 33.75 + INC=/rustroot/include:/usr/include
#23 33.75 + GCC_PLUGIN_TARGET=i686-pc-linux-gnu
#23 33.75 + [[ i686-pc-linux-gnu == \i\6\8\6\-\p\c\-\l\i\n\u\x\-\g\n\u ]]
#23 33.75 + hide_output cmake ../llvm -DCMAKE_C_COMPILER=/rustroot/bin/gcc -DCMAKE_CXX_COMPILER=/rustroot/bin/g++ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/rustroot -DCOMPILER_RT_BUILD_SANITIZERS=OFF -DCOMPILER_RT_BUILD_XRAY=OFF -DCOMPILER_RT_BUILD_MEMPROF=OFF -DCOMPILER_RT_BUILD_CTX_PROFILE=OFF -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_INCLUDE_BENCHMARKS=OFF -DLLVM_INCLUDE_TESTS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF '-DLLVM_ENABLE_PROJECTS=clang;lld;compiler-rt;bolt' -DLLVM_BINUTILS_INCDIR=/rustroot/lib/gcc/x86_64-pc-linux-gnu/9.5.0/plugin/include/ -DC_INCLUDE_DIRS=/rustroot/include:/usr/include
#23 51.79 ++ nproc
#23 51.79 + hide_output make -j4
#23 81.80 Fri Feb 21 04:44:46 UTC 2025 - building ...

Kobzol · 2025-02-21T16:21:06Z

Let's try again.

@bors retry

bors · 2025-02-22T22:58:20Z

⌛ Testing commit 28d589c with merge 0769736...

bors · 2025-02-23T02:04:05Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 0769736 to master...

rust-timer · 2025-02-23T03:20:53Z

Finished benchmarking commit (0769736): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	7
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-0.2%	[-0.3%, 0.1%]	8

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.934s -> 770.476s (-0.06%)
Artifact size: 360.98 MiB -> 359.65 MiB (-0.37%)

rylev · 2025-02-25T20:05:48Z

As previously pointed out, this is actually quite small perf difference for an LLVM change

@rustbot label: +perf-regression-triaged

Update host LLVM to 20.1 on CI

28d589c

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 17, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 17, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2025

Auto merge of rust-lang#137189 - Kobzol:update-host-llvm, r=<try>

bf1902f

Update host LLVM to 20.1 on CI r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 18, 2025

rustbot assigned nikic Feb 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2025

Auto merge of rust-lang#137189 - Kobzol:update-host-llvm, r=nikic

49bca9a

Update host LLVM to 20.1 on CI r? `@ghost`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025

Auto merge of rust-lang#137189 - Kobzol:update-host-llvm, r=nikic

29656bd

Update host LLVM to 20.1 on CI r? `@ghost`

workingjubilee added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Feb 21, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2025

bors merged commit 0769736 into rust-lang:master Feb 23, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Feb 23, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update host LLVM to 20.1 on CI #137189

Update host LLVM to 20.1 on CI #137189

Kobzol commented Feb 17, 2025

Kobzol commented Feb 17, 2025

This comment has been minimized.

bors commented Feb 17, 2025

bors commented Feb 17, 2025

This comment has been minimized.

rust-timer commented Feb 18, 2025

Kobzol commented Feb 18, 2025

nikic commented Feb 18, 2025

bors commented Feb 18, 2025

bors commented Feb 20, 2025

rust-log-analyzer commented Feb 20, 2025

bors commented Feb 20, 2025

Kobzol commented Feb 20, 2025

bors commented Feb 21, 2025

bors commented Feb 21, 2025

rust-log-analyzer commented Feb 21, 2025

Kobzol commented Feb 21, 2025 •

edited

Loading

bors commented Feb 22, 2025

bors commented Feb 23, 2025

rust-timer commented Feb 23, 2025

rylev commented Feb 25, 2025

Update host LLVM to 20.1 on CI #137189

Update host LLVM to 20.1 on CI #137189

Conversation

Kobzol commented Feb 17, 2025

Kobzol commented Feb 17, 2025

This comment has been minimized.

bors commented Feb 17, 2025

bors commented Feb 17, 2025

This comment has been minimized.

rust-timer commented Feb 18, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Kobzol commented Feb 18, 2025

nikic commented Feb 18, 2025

bors commented Feb 18, 2025

bors commented Feb 20, 2025

rust-log-analyzer commented Feb 20, 2025

bors commented Feb 20, 2025

Kobzol commented Feb 20, 2025

bors commented Feb 21, 2025

bors commented Feb 21, 2025

rust-log-analyzer commented Feb 21, 2025

Kobzol commented Feb 21, 2025 • edited Loading

bors commented Feb 22, 2025

bors commented Feb 23, 2025

rust-timer commented Feb 23, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

rylev commented Feb 25, 2025

Kobzol commented Feb 21, 2025 •

edited

Loading