Rollup of 8 pull requests #137608
Merged
Rollup of 8 pull requests #137608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refers to a `PredicatePolarity::Reserved` which no longer exists.
The force inlining attribute isn't is never used with `#![..]` attribute syntax, only `#[..]` syntax.
…owLii adjust_abi: make fallback logic for ABIs a bit easier to read I feel like the match guards here make this unnecessarily harder to follow.
Improve behavior of `IF_LET_RESCOPE` around temporaries and place expressions Heavily reworks the `IF_LET_RESCOPE` to be more sensitive around 1. temporaries that get consumed/terminated and therefore should not trigger the lint, and 2. borrows of place expressions, which are not temporary values. Fixes rust-lang#137411
…tebank Fix invalid suggestion from type error for derive macro Fixes rust-lang#136343 r? `@estebank` I didn't use `from_expansion` to avoid it because of testcase `tests/ui/typeck/issue-110017-format-into-help-deletes-macro.rs`: https://github.com/chenyukang/rust/blob/11959a8b6e75d2c55500a703070a248342d29549/tests/ui/typeck/issue-110017-format-into-help-deletes-macro.rs#L34-L37 This type error could come up with a proper fix.
… r=notriddle Add rustdoc-gui regression test for rust-lang#137082 Fixes rust-lang#137082. Added new commands in `browser-ui-test` allowing us to add a regression test for rust-lang#137082 and also another to copy code examples content. r? `@notriddle`
Don't doc-comment BTreeMap<K, SetValZST, A> This otherwise shows up in documentation as an empty impl block (worse, at the *top* of the docs above the public impls).
…=RalfJung remove `simd_fpow` and `simd_fpowi` Discussed in rust-lang#137555 These functions are not exposed from `std::intrinsics::simd`, and not used anywhere outside of the compiler. They also don't lower to particularly good code at least on the major ISAs (I checked x86_64, aarch64, s390x, powerpc), where the vector is just spilled to the stack and scalar functions are used for the actual logic. r? `@RalfJung`
…nt, r=fmease type_ir: remove redundant part of comment This comment refers to a `PredicatePolarity::Reserved` which no longer exists.
…, r=fmease feature: fix typo in attribute description The force inlining attribute isn't is never used with `#![..]` attribute syntax, only `#[..]` syntax.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=5 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 4ecd70ddd1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 25, 2025
|
Finished benchmarking commit (85abb27): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.644s -> 770.518s (-0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
IF_LET_RESCOPEaround temporaries and place expressions #137444 (Improve behavior ofIF_LET_RESCOPEaround temporaries and place expressions)simd_fpowandsimd_fpowi#137595 (removesimd_fpowandsimd_fpowi)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup