Various coretests improvements #137679
Open
Various coretests improvements #137679
+25
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides the test=false flag in Cargo.toml and it shouldn't be necessary as --tests is already passed.
rustbot
added
A-testsuite
bjorn3
force-pushed
the
coretests_improvements
branch
from
fc146ad to
a535d6d
Compare
It is reasonable to expect that ./x.py test core is enough to run tests when you are working on core. In addition it seems like CI for wasm32 at least doesn't run coretests currently, which this commit fixes.
bjorn3
force-pushed
the
coretests_improvements
branch
from
a535d6d to
169e731
Compare
This was referenced Feb 26, 2025
I don't think it does; miri-test-libstd does not use |
|
Removed it from the PR description again. |
|
The changes make sense, but I don't know much about how std/core tests are configured, so would appreciate another look. |
|
Sure, I'll also take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is not yet strictly necessary as directly testing libcore works though useless work, but will be necessary once #136642 migrates the liballoc tests into a separate package. The second commit fixes #137478 and ensures that coretests actually gets tested on all CI job. The third commit fixes an error that didn't get caught because coretests doesn't run on the wasm32 CI job.