remove deprecated stuff from std::fmt docs #19212
Conversation
| @@ -104,63 +104,15 @@ It is illegal to put positional parameters (those without names) after arguments | |||
| which have names. Like with positional parameters, it is illegal to provide | |||
| named parameters that are unused by the format string. | |||
|
|
|||
| ### Argument types | |||
There was a problem hiding this comment.
I think that #19209 was just referring to the :d and :u modifiers, you can still specify different types for arguments so we may not want to delete the documentation wholesale
There was a problem hiding this comment.
I was reading that, but the whole section basically relies on :d, so I just chucked it. Which modifiers do we actually have now?
There was a problem hiding this comment.
Could you re-word it with respect to :x or :o (hex or octal). The list of format specifiers below is accurate for today's state, I just forgot to update the other text :(.
steveklabnik
force-pushed
the
doc_format_specifiers
branch
from
988498b to
9c7190d
Compare
| There are various parameters which do require a particular type, however. Namely if the syntax | ||
| `{:.*s}` is used, then the number of characters to print from the string precedes the actual string | ||
| and must have the type `uint`. Although a `uint` can be printed with `{:u}`, it is illegal to | ||
| reference an argument as such. For example, this is another invalid format string: |
There was a problem hiding this comment.
These still reference :s and :u, perhaps something like:
There are various parameters which do require a particular type, however. Namely if the syntax {:.*} is used, then the number of characters to print precedes the actual object being formatted, and the number of characters must have the type uint. Although a uint can be printed with {}, it is illegal to reference an argument as such. For example this is another invalid format string:
{:.*} {0}
671f2ec to
c5f06a2
Compare
|
@alexcrichton how about now? |
|
Thanks @steveklabnik! |
| # trait SomeName<T> { | ||
| # use std::fmt; | ||
| # struct Foo; // our custom type | ||
| # impl fmt::Show for Foo { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter) -> fmt::Result; |
There was a problem hiding this comment.
That isn't going to pass, it's not an implementation.
steveklabnik
force-pushed
the
doc_format_specifiers
branch
from
c5f06a2 to
7dadb14
Compare
minor: sync from downstream
Fixes #19209