Use quiet tests by default #51367
Merged
Use quiet tests by default #51367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
requested changes
Jun 5, 2018
There was a problem hiding this comment.
We'll want to change https://github.com/rust-lang/rust/blob/master/src/ci/run.sh#L31 such that the condition is inverted and it passes disable-quiet-tests. We can probably unconditionally enable step timings if that makes the code easier.
(This is because otherwise diagnosing which test failed or "timed out" is near-impossible).
|
I decided that |
|
Ping from triage @eddyb! This PR needs your review. |
Mark-Simulacrum
approved these changes
Jun 19, 2018
|
@bors r+ |
|
📌 Commit 0c1bcd3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 19, 2018
Use quiet tests by default r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb