Revert #49719 #51417
Merged
Revert #49719 #51417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
pietroalbini
added
beta-nominated
|
@bors r+ |
|
📌 Commit 1df7817 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 (needs to be backported into beta) |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jun 7, 2018
…tsakis Revert rust-lang#49719 This also needs to be backported into beta. Fixes rust-lang#51416. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jun 7, 2018
Rollup of 9 pull requests Successful merges: - #51186 (Remove two redundant .nll.stderr files) - #51283 (Deny #[cfg] and #[cfg_attr] on generic parameters.) - #51368 (Fix the use of closures within #[panic_implementation]) - #51380 (Remove dependency on fmt_macros from typeck) - #51389 (rustdoc: Fix missing stability and src links for inlined external macros) - #51399 (NLL performance boost) - #51407 (Update RLS and Rustfmt) - #51417 (Revert #49719) - #51420 (Tries to address the recent network issues) Failed merges:
|
Marking this as beta-accepted since the compiler team decided at the last meeting to rollback the change, which is already in beta. |
pietroalbini
added
the
beta-accepted
kennytm
removed
the
beta-nominated
|
Argh, I'm late and this is merged already. |
bors
added a commit
that referenced
this pull request
Jun 16, 2018
Remove `?` macro separator compatibility note from 1.27 release notes The implementation has been reverted in #51417, so this no longer applies to 1.27.0. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also needs to be backported into beta.
Fixes #51416.
r? @nikomatsakis