-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stdsimd #51695
Update stdsimd #51695
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @kennytm |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Added WIP label to wait for rust-lang/stdarch#492 |
@bors r+ |
📌 Commit afa309b has been approved by |
@bors rollup |
rust-lang/stdarch#494, not in this PR yet. |
Update stdsimd Closes rust-lang#51691
@bors r- rollup- Cannot compile on s390x due to rust-lang/stdarch#467. Error log: #51782 (comment)
|
@est31 so I think I found the issue. https://github.com/rust-lang/rust/blob/master/src/etc/wasm32-shim.js#L109 needs to be updated with the missing functions. At most those should be cc @alexcrichton it seems that rustc has a system for running at least some of the unit tests for |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
6eb5ab1
to
1df347a
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
They are all needed now due to the stdsimd update.
wasm is green now: https://travis-ci.org/rust-lang/rust/builds/399147037 I've squashed and removed the temporary test stuff. re-r? @alexcrichton |
or @kennytm :) |
@bors: r+ |
📌 Commit 56e4625 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
It appears that as a result of this, things linking against only Was this known/expected? Is there by chance a discussion about this somewhere that I couldn't find? |
@alex not expected but we have seen the partial downfall of that here due to the wasm issues. Could you file an issue? Also, on which platform is this happening? cc @alexcrichton are the types |
Closes #51691