Fix many warnings. #6632
Closed
Fix many warnings. #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
bors
added a commit
that referenced
this pull request
May 20, 2013
…inger With this, the build is almost 100% warning free. One more can be fixed after the next snapshot, and there's one other that I filed an issue about already.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
Now we can lint for the expressions like `_&_>>_`, `_<<_^_`, etc. And will suggest to add parentheses like `_&(_>>_)` and `(_<<_)^_`. I get implementation suggestions from [https://github.com/rust-lang/rust-clippy/pull/8735#pullrequestreview-954273477](https://github.com/rust-lang/rust-clippy/pull/8735#pullrequestreview-954273477). changelog: extended [`precedence`] to lint for bit masking and bit shifting without parentheses fixes rust-lang#6632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the build is almost 100% warning free.
One more can be fixed after the next snapshot, and there's one other that I filed an issue about already.