Clarifies how to tag users for assigning PRs #66826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
mlodato517
commented
Nov 27, 2019
mlodato517
commented
Nov 27, 2019
|
r? @Dylan-DPC |
Dylan-DPC-zz
previously requested changes
Nov 28, 2019
|
@bors r+ rollup |
|
📌 Commit 77f2ac4 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
…ssage-assigner, r=Dylan-DPC Clarifies how to tag users for assigning PRs Clarifies language of where to put `r?` text to assign a particular user. Mostly a follow up of [this discussion](rust-lang#66797 (comment)).
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
…ssage-assigner, r=Dylan-DPC Clarifies how to tag users for assigning PRs Clarifies language of where to put `r?` text to assign a particular user. Mostly a follow up of [this discussion](rust-lang#66797 (comment)).
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Rollup of 11 pull requests Successful merges: - #66379 (Rephrase docs in for ptr) - #66589 (Draw vertical lines correctly in compiler error messages) - #66613 (Allow customising ty::TraitRef's printing behavior) - #66766 (Panic machinery comments and tweaks) - #66791 (Handle GlobalCtxt directly from librustc_interface query system) - #66793 (Record temporary static references in generator witnesses) - #66808 (Cleanup error code) - #66826 (Clarifies how to tag users for assigning PRs) - #66837 (Clarify `{f32,f64}::EPSILON` docs) - #66844 (Miri: do not consider memory allocated by caller_location leaked) - #66872 (Minor documentation fix) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies language of where to put
r?text to assign a particular user. Mostly a follow up of this discussion.