Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt deleting a bunch of code after upgrading to 0.7 #1277

Closed
bgourlie opened this issue Jan 17, 2017 · 3 comments
Closed

rustfmt deleting a bunch of code after upgrading to 0.7 #1277

bgourlie opened this issue Jan 17, 2017 · 3 comments
Labels
bug Panic, non-idempotency, invalid code, etc. p-high

Comments

@bgourlie
Copy link

I just upgraded to rustfmt 0.7. Running cargo fmt deletes a bunch of code in some files while (weirdly enough) also inserting code from other files. To reproduce:

@nrc nrc added bug Panic, non-idempotency, invalid code, etc. p-high labels Jan 17, 2017
@mulkieran
Copy link

Having a similar problem:

-#![allow(dead_code)] // only temporary, until more stuff is filled in⏎
+ // only temporary, until more stuff is filled in⏎

Note that the #![allow(dead_code)] is simply removed.

@nrc
Copy link
Member

nrc commented Jan 17, 2017

This sounds like #1229. I investigated that, see #1229 (comment)

@mulkieran's thing sounds like a separate issue.

@mulkieran
Copy link

@nrc you must be right. My problem seems to have been introduced by the 0.7.0 release; 0.6.3 makes no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc. p-high
Projects
None yet
Development

No branches or pull requests

3 participants