-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fn_args_layout
config option
#4149
Labels
Comments
ayazhafiz
added a commit
to ayazhafiz/rustfmt
that referenced
this issue
May 9, 2020
See rust-lang#4149 for more details. This change is targeted for rustfmt 2.0. Closes rust-lang#4149
This was referenced Sep 17, 2020
Closed
Reopening for 1.x according to @calebcartwright's comment: "there should be a path to a "soft" deprecation where we just print a warning when encountering the option for user awareness, but automatically map the value over to the new option. [...] anyone that wants to work on that could use the commits from #4163 as a building block, and then just add the warning/mapping behavior on top" |
7 tasks
kayagokalp
added a commit
to FuelLabs/sway
that referenced
this issue
May 4, 2023
#4530) ## Description Since rust-lang/rustfmt#4149 is released with latest rust toolchain 1.69, we are seeing some warnings from rustfmt. This PR addresses the depreciation note in our `rustfmt.toml`.
6 tasks
kayagokalp
added a commit
to FuelLabs/fuels-rs
that referenced
this issue
Jun 16, 2023
#994) Since rust-lang/rustfmt#4149 is released with latest rust toolchain 1.69, we are seeing some warnings from rustfmt. This PR addresses the depreciation note coming from rustfmt.toml.
ak-tech007
added a commit
to ak-tech007/Rust-SDK
that referenced
this issue
Dec 6, 2024
…` (#994) Since rust-lang/rustfmt#4149 is released with latest rust toolchain 1.69, we are seeing some warnings from rustfmt. This PR addresses the depreciation note coming from rustfmt.toml.
2moe
added a commit
to 2moe/tinyvec
that referenced
this issue
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We previously (#3803) refactored the
arg
name toparam
internally within rustfmt where appropriate to reflect the upstream changes (rust-lang/rust#62426), but did not change the public/external-facingfn_args_layout
config option because that would have been a breaking change.However, this config option is indeed used as part of the formatting of the parameters in a fn signature, not in the formatting of args in a fn call. As such this should also be renamed as part of the major version release (
fn_params_layout
seems like a reasonable name)@topecongiro I've added this to the 2.0 milestone per our previous discussion in #3803 (comment), but of course feel free to change that if you think we should defer it.
Below are the steps involved for anyone interested in working on this:
Rename the configuration option and update the help text in
rustfmt-core/rustfmt-lib/src/config.rs
rustfmt/rustfmt-core/rustfmt-lib/src/config.rs
Lines 111 to 112 in 7194d52
Rename the corresponding test files/update config references under
rustfmt-core/rustfmt-lib/tests/{source,target}
tests/target
)tofn_params_layout-vertical.rs
and the inline config to be// rustfmt-fn_params_layout: Vertical
tests/{source,target}/configs/fn_args_layout
, rename the directory and update the inline config in the files with the new config option namerustfmt/rustfmt-core/rustfmt-lib/tests/source/fn_args_layout-vertical.rs
Lines 1 to 2 in 7194d52
Rename/update the corresponding section in Configurations.md
The text was updated successfully, but these errors were encountered: