Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty tuple struct def with comment properly #1453

Merged
merged 2 commits into from
May 2, 2017
Merged

Handle empty tuple struct def with comment properly #1453

merged 2 commits into from
May 2, 2017

Conversation

topecongiro
Copy link
Contributor

This PR closes #919.

@topecongiro topecongiro changed the title Bug/empty struct with comment Handle empty tuple struct def with comment properly Apr 14, 2017
@topecongiro topecongiro force-pushed the bug/empty-struct-with-comment branch from 7bda4ca to 1cd3287 Compare April 14, 2017 13:43
nrc
nrc suggested changes May 1, 2017
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There's just one nit to fix in the test.

tests/source/structs.rs
@@ -166,7 +166,7 @@ struct Foo {

}
struct Foo { /* comment */ }
struct Foo();
struct Foo( /* comment */ );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new line should be in addition to the old one, not replace it.

@topecongiro topecongiro force-pushed the bug/empty-struct-with-comment branch from 1cd3287 to 084824a Compare May 1, 2017 06:41
@topecongiro
Copy link
Contributor Author

Fixed a nit in the test.

@nrc
Copy link
Member

nrc commented May 1, 2017

Thanks for the fix, needs a rebase now, sorry.

@topecongiro topecongiro force-pushed the bug/empty-struct-with-comment branch from 084824a to 93dae1a Compare May 2, 2017 01:22
@topecongiro
Copy link
Contributor Author

Rebased.

@nrc nrc merged commit 59d66c3 into rust-lang:master May 2, 2017
@topecongiro topecongiro deleted the bug/empty-struct-with-comment branch June 16, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle empty struct defs properly
2 participants
@topecongiro @nrc