Remove disable_all_formatting #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
LGTM!
On a related note, I opened #4148 to propose something like an FAQ that folks can reference, and I think this is a great example of something we could include in that doc. For example:
If you want to disable rustfmt in your project, use the ignore setting with a value of...
|
@calebcartwright Sounds good to me; we lack good documentation. |
bradleypmartin
pushed a commit
to bradleypmartin/rustfmt
that referenced
this pull request
May 25, 2020
|
This should never have been removed since |
|
Seems like master goes in a different direction (#5026), backport not needed |
karyon
added
1x-backport:completed
1x-backport:n/a
and removed
backport-triage
1x-backport:completed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
disable_all_formatting, as we can replace it withignore.Close #3388.