-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build #3 by correct errors found by awesomebot #309
Comments
Regarding the 404s from crates.io i've opened rust-lang/crates.io#788 I think PRs are not strictly necessary for Travis. The commit which triggered https://travis-ci.org/rust-unofficial/awesome-rust/builds/244830080 was not done via a PR. I guess in the future we'll see more deprecated/moved URLs etc. long after the change was made. I don't suspect many new PRs to have issues regarding URLs. |
Without looking at the crates.io, here are the issues found
|
Passes, thanks. |
https://travis-ci.org/rust-unofficial/awesome-rust/builds/244830080
We shouldn't normally need to do this with future pull requests, now that we've enabled on travis.
I would also make the suggestion that all maintainers should start using PR rather than editing the file directly so we can all utilise awesomebot validation via travis.
cc @kud1ing @Manishearth @luciusmagn @Freyskeyd
The text was updated successfully, but these errors were encountered: