Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #3 by correct errors found by awesomebot #309

Closed
booyaa opened this issue Jun 20, 2017 · 4 comments
Closed

Fix build #3 by correct errors found by awesomebot #309

booyaa opened this issue Jun 20, 2017 · 4 comments

Comments

@booyaa
Copy link
Contributor

booyaa commented Jun 20, 2017

https://travis-ci.org/rust-unofficial/awesome-rust/builds/244830080

We shouldn't normally need to do this with future pull requests, now that we've enabled on travis.

I would also make the suggestion that all maintainers should start using PR rather than editing the file directly so we can all utilise awesomebot validation via travis.

cc @kud1ing @Manishearth @luciusmagn @Freyskeyd

@kud1ing
Copy link
Contributor

kud1ing commented Jun 20, 2017

Regarding the 404s from crates.io i've opened rust-lang/crates.io#788

I think PRs are not strictly necessary for Travis. The commit which triggered https://travis-ci.org/rust-unofficial/awesome-rust/builds/244830080 was not done via a PR.

I guess in the future we'll see more deprecated/moved URLs etc. long after the change was made. I don't suspect many new PRs to have issues regarding URLs.

@awesome-bot
Copy link

Without looking at the crates.io, here are the issues found

Issues :-(
> Links 
  1. [L088]  https://gitlab.ethcore.io/parity/parity/badges/master/build.svg hostname "gitlab.ethcore.io" does not match the server certificate 
  2. [L088]  https://gitlab.ethcore.io/parity/parity/commits/master hostname "gitlab.ethcore.io" does not match the server certificate 
  3. [L431]  https://arrayfire.com/ SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed 
  4. [L491] 301 https://symas.com/mdb/  → https://symas.com/lightning-memory-mapped-database/ 
> Dupes 
  01. [L164] https://github.com/racer-rust/racer
  02. [L199] https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb
  03. [L199] https://code.visualstudio.com/
  04. [L331] https://github.com/zonyitoo/coio-rs
  05. [L331] https://api.travis-ci.org/zonyitoo/coio-rs.svg?branch=master
  06. [L331] https://travis-ci.org/zonyitoo/coio-rs
  07. [L419] https://en.wikipedia.org/wiki/Limited-memory_BFGS
  08. [L586] https://github.com/serde-rs/serde
  09. [L818] https://github.com/sunng87/handlebars-rust
  10. [L859] https://github.com/hyperium/hyper
  11. [L859] https://api.travis-ci.org/hyperium/hyper.svg?branch=master
  12. [L859] https://travis-ci.org/hyperium/hyper

@kud1ing
Copy link
Contributor

kud1ing commented Jun 21, 2017

Passes, thanks.

@kud1ing kud1ing closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@booyaa @kud1ing @awesome-bot and others