Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jojo.logging.logger responsible for opening/closing logfile #7

Open
ryedin opened this issue Oct 25, 2010 · 0 comments
Open

Make jojo.logging.logger responsible for opening/closing logfile #7

ryedin opened this issue Oct 25, 2010 · 0 comments
Labels

Comments

@ryedin
Copy link
Owner

ryedin commented Oct 25, 2010

currently, we're requiring a fileDescriptor (fd) object to be passed in that's already open for append.

we really should encapsulate that within the FSM for the logger itself, and just pass in a logFilePath by default, and optionally allow the fd passing technique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant