Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5.2 support #85

Closed
kylekermgard opened this issue Jan 3, 2018 · 5 comments
Closed

Rails 5.2 support #85

kylekermgard opened this issue Jan 3, 2018 · 5 comments

Comments

@kylekermgard
Copy link

It looks like baby_squeel isn't working with joins in rails 5.2.0.beta2.
@rzane
Copy link
Owner

rzane commented Jan 3, 2018

Yup, this is a top priority. I'll work on this ASAP.

@rzane
Copy link
Owner

rzane commented Jan 12, 2018 •
edited
Loading

Okay, I spend some time looking into this. It should be solvable, but it's going to take quite a bit more research. So far, I've identified the source of the changes that caused 5.2 to break:

Also, most of the failures are due to missing or extra parens in the generated SQL.

@rzane
Copy link
Owner

rzane commented Mar 9, 2018

I'm working on this in #87. It's really close!

@rzane rzane mentioned this issue Mar 9, 2018
Merged
2 tasks
@kapso
Copy link

kapso commented Apr 21, 2018

has_many & has_one via through is breaking on Rails 5.2 because of this gem

@rzane
Copy link
Owner

rzane commented Apr 21, 2018

Yeah 5.2 is currently broken. Support for 5.2 waiting on this PR: #87

@rzane rzane closed this as completed in #87 Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kapso @kylekermgard @rzane