Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feature requests #4

Open
1 of 5 tasks
smol-ninja opened this issue Jan 7, 2025 · 2 comments
Open
1 of 5 tasks

Some feature requests #4

smol-ninja opened this issue Jan 7, 2025 · 2 comments

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Jan 7, 2025

Some feature requests

  • Add --help command
  • Revert when foundry.toml is not found instead of returning Vec::new()
  • Don't deploy on sepolia if chain provided is incorrect. For example, deploy-multi-chain 12ewdf2wqe --script DeployFlow.s.sol continues to deploy on sepolia.
  • Rename v2-deployments to deployments
  • Improve logs. For example, I ran the command in a non foundry project and this is what it prints in the terminal.
@smol-ninja smol-ninja added type: feature New feature or request. effort: high Large or difficult task. priority: 2 We will do our best to deal with this. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Jan 7, 2025
@andreivladbrg
Copy link
Member

andreivladbrg commented Jan 13, 2025

Thanks for posting these.

Re point 2 and 5, that's why I've added the assumptions in the README:

https://github.com/sablier-labs/multichain-deployer?tab=readme-ov-file#assumptions

Also, when I built this I didn't design it to be general-purpose but rather to automate specific steps in our internal workflow

@smol-ninja
Copy link
Member Author

Thanks for posting these

My pleasure.

when I built this I didn't design it to be general-purpose but rather to automate specific steps in our internal workflow

I know. There is no need to bother about these features until Sablier becomes a multiVM protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants