Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Prettier support 💄 #341

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Prettier support 💄 #341

merged 1 commit into from
Apr 25, 2017

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Apr 23, 2017

Changes the linter configuration to support Prettier and adds another npm script to format the code.

Closes #336

@pirelenito pirelenito added the wip label Apr 23, 2017
@pirelenito
Copy link
Member Author

pirelenito commented Apr 23, 2017

I've just adapted the ESLint configuration to support Prettier. Next step is attempting to run the formater.

I've also found solutions that does the formatting automatically, but I'm not sure that is a good idea: https://github.com/danielterwiel/prettier-eslint-webpack-plugin/blob/master/package.json

It feels to me that it might make sense to have a prettier-eslint-loader that works in the same way as the eslint-loader but checks for any formatting issue... letting the user know how to fix it.

@pirelenito
Copy link
Member Author

I'll merge the linting rules, and we can work in the formatting as a separated PR.

@pirelenito pirelenito merged commit 16e3d9d into v9 Apr 25, 2017
@pirelenito pirelenito deleted the prettier branch April 25, 2017 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant