Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in the docs the Sonatype user tokens might contain special characters #309

Closed
bcarter97 opened this issue Sep 27, 2024 · 4 comments · Fixed by #310
Closed

Mention in the docs the Sonatype user tokens might contain special characters #309

bcarter97 opened this issue Sep 27, 2024 · 4 comments · Fixed by #310

Comments

@bcarter97
Copy link
Contributor

bcarter97 commented Sep 27, 2024

After switching to the new User tokens I spent a few hours banging my head trying to figure out what I'd done wrong. Using Travis I already had my passphrase quoted, I didn't expect the username to contain special characters and overlooked it as the cause. It might be worth adding a tiny note to the docs for this? If so I can raise a PR

@eed3si9n
Copy link
Member

Doesn't it already say

SONATYPE_PASSWORD: The password you use to log into https://s01.oss.sonatype.org/ (or https://oss.sonatype.org/ if your Sonatype account was created before February 2021). Alternatively, the password part of the user token if you generated one above. For Travis Only: If the password contains bash special characters, make sure to escape it by wrapping it in single quotes 'my?pa$$word', see Travis Environment Variables.

@bcarter97
Copy link
Contributor Author

bcarter97 commented Sep 27, 2024

It does indeed, but I didn't consider the user token "user" it generates could contain special characters too, and overlooked this. Obviously with some critical thinking you could apply the same logic from the password, but often these things are just skimmed for quick answers 😉

@eed3si9n
Copy link
Member

I see. the token user name not the password. Feel free to send a PR to improve the doc on this.

@bcarter97
Copy link
Contributor Author

I have raised #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants