Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiscriminatorReweightDensity and ReweightDensity #118

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

antoinedemathelin
Copy link
Contributor

Hi,
I make small corrections for both methods, as discussed in #112

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (e054799) to head (f899dae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   91.70%   91.68%   -0.03%     
==========================================
  Files          43       43              
  Lines        3341     3344       +3     
==========================================
+ Hits         3064     3066       +2     
- Misses        277      278       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoinedemathelin
Copy link
Contributor Author

Codecov is red ?
However, I did not add any new "untested" line...

@rflamary rflamary merged commit 6adc7dc into scikit-adaptation:main Mar 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants