Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove masked inputs only if estimator does not accept sample_domain #123

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

kachayev
Copy link
Collaborator

Per the discussion in Slack.

Selector now removes masked inputs if the base estimator does not accept sample_domain through the routing (e.g. any sklearn estimator out there). The contract is that if the estimator declares sample_domain as a parameter, it should be able to deal with inputs being partially masked (presumably targets).

@kachayev kachayev added enhancement New feature or request domain-aware api labels Feb 29, 2024
@kachayev kachayev requested a review from rflamary February 29, 2024 23:10
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (8726d54) to head (9afa131).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          43       43           
  Lines        3341     3341           
=======================================
  Hits         3064     3064           
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice

@rflamary rflamary merged commit e054799 into main Mar 1, 2024
10 checks passed
@kachayev kachayev deleted the fix-mask-removal branch March 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-aware api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants