Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Implement CircularValidation as a scorer #124

Merged

Conversation

YanisLalou
Copy link
Collaborator

@YanisLalou YanisLalou commented Mar 1, 2024

Fixes #111
Paper: https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=4803844&tag=1
Process described in part [5] and [6].

Small thing not in the paper but implemented:

  • If the estimator predicts always the same value, then we assume that the backward_estimator will also predicts always the same value.

--> Why? Because for some estimators, if you train them with np.unique(y) = 1 you get ValueErrors (happens with SVC).

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (6d59191) to head (6360626).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   91.72%   91.85%   +0.12%     
==========================================
  Files          43       43              
  Lines        3348     3400      +52     
==========================================
+ Hits         3071     3123      +52     
  Misses        277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YanisLalou YanisLalou changed the title Implement CircularValidation as a scorer [TO_REVIEW] Implement CircularValidation as a scorer Mar 1, 2024
Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

@rflamary rflamary changed the title [TO_REVIEW] Implement CircularValidation as a scorer [MRG] Implement CircularValidation as a scorer Mar 1, 2024
@rflamary rflamary merged commit 4950a16 into scikit-adaptation:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Circular Validation Strategy
2 participants