Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO_REVIEW] _find_y_type return enum #125

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

YanisLalou
Copy link
Collaborator

Fixes #85

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (6adc7dc) to head (c2f993f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   91.71%   91.72%           
=======================================
  Files          43       43           
  Lines        3344     3348    +4     
=======================================
+ Hits         3067     3071    +4     
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YanisLalou YanisLalou changed the title _find_y_type return enum [TO_REVIEW] _find_y_type return enum Mar 1, 2024
@kachayev
Copy link
Collaborator

kachayev commented Mar 1, 2024

Cool! The only question I have: should it be 'continuous' vs. 'discrete'? Or 'classification' vs. 'regression' (though it is not exactly a 'type of y', more like type of a task).

@YanisLalou
Copy link
Collaborator Author

Cool! The only question I have: should it be 'continuous' vs. 'discrete'? Or 'classification' vs. 'regression' (though it is not exactly a 'type of y', more like type of a task).

Yes it makes more sense to have 'continuous' vs. 'discrete'

@kachayev kachayev merged commit 6d59191 into scikit-adaptation:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_find_y_type to return enum
2 participants